Exclude emscripten/pybuilddir.txt from the crate package - #5432
Closed
nikkon-dev wants to merge 1 commit into
Closed
nikkon-dev wants to merge 1 commit into
nikkon-dev wants to merge 1 commit into
Conversation
fixes PyO3#5431 Signed-off-by: Nik Konyuchenko <spaun2002mobile@gmail.com>
nikkon-dev
force-pushed
the
nikkon-dev/fix5431
branch
from
September 9, 2025 22:22
f81e954 to
0949aaa
Compare
Member
|
Thanks for the report & the proposed fix. I think we can just delete the file - #5456 |
Member
|
Closed as #5456 got merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5431
Thank you for contributing to PyO3!
By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.
Please consider adding the following to your pull request:
docs:if this is a docs-only change to skip the checkci:if this is a ci-only change to skip the checkPyO3's CI pipeline will check your pull request, thus make sure you have checked the
Contributing.mdguidelines. To run most of its tests locally, you can runnox. Seenox --list-sessionsfor a list of supported actions.